fix: don't crash when seeing -1 in code cov #11131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @paperdave, your commit has failing tests :( 💪 1 failing tests Darwin AARCH64
💻 2 failing tests Darwin x64 baseline
💻 4 failing tests Darwin x64
🐧💪 1 failing tests Linux AARCH64🐧🖥 1 failing tests Linux x64
|
|
Great, but needs tests. |
| }`, | ||
| }); | ||
| const result = Bun.spawnSync([bunExe(), "test", "--coverage"], { | ||
| cwd: dir, |
There was a problem hiding this comment.
Suggested change
| cwd: dir, | |
| cwd: dir, | |
| stdio: ['inherit', 'inherit', 'inherit'], |
Jarred-Sumner
force-pushed
the
dave/codecov
branch
from
f08179a
to
fbc730e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10836
Fixes #10621
Fixes #10395
Fixes #9681
Fixes #10501
Does not fix already existing cases where code coverage reports less than 100% of functions when 100% of the lines are executed.