fix(windows): build all dependencies with proper cpu target #10884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperdave
changed the title
dylan-conway
reviewed
May 7, 2024
src/output.zig
Outdated
| @@ -16,7 +16,7 @@ const SystemTimer = @import("./system_timer.zig").Timer; | |||
|
|
|||
| // These are threadlocal so we don't have stdout/stderr writing on top of each other | |||
| threadlocal var source: Source = undefined; | |||
| threadlocal var source_set: bool = false; | |||
| pub threadlocal var source_set: bool = false; | |||
There was a problem hiding this comment.
does this need to be pub?
There was a problem hiding this comment.
the goal was to make crash_handler not use output if the source was not set, but i didn't keep that behavior.
There was a problem hiding this comment.
okay so can we remove this change?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10856
Fixes #10435
Fixes #10460
Fixes #10545
Fixes #10546
Fixes #10547
Fixes #10578
Fixes #10583
Fixes #10615
Fixes #10629
Fixes #10700
Fixes #10755
Fixes #10756
For #10788, this will resolve their third point.
Fixes #10790
Fixes #10798
Fixes #10841
Fixes #10853
Besides 10788, all of the above are the same exact issue report.
What went wrong is when compiling dependencies is the logic in every dependency script is
This overrides the baseline state of the shell to haswell, which will unintentionally compile newer code for older cpus.
We also never even tried compiling tcc correctly. The proper flags are added.
When using SDE, I noticed a very odd failure reported in
WTF::initialize, which names the current thread. This applies for any JS entrypoint, which is different from the mostly install-related ones above (makes sense, sincelibarchiveis a notable dependency, while the js runtime in general is mostly just JSC + our own code + simdutf). I dont think the change in JSC is significant but it is definetly on the safer side to do this.