Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confirm is never true in windows #10802

Merged
merged 6 commits into from May 7, 2024
Merged

Conversation

rcaselles
Copy link
Contributor

@rcaselles rcaselles commented May 3, 2024

What does this PR do?

It fixes confirm dialog was always false in bundows

How did you verify your code works?

With the new test added

this fixes #10643

Copy link
Collaborator

@paperdave paperdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, can you double check my note.

src/bun.js/webcore.zig Outdated Show resolved Hide resolved
@rcaselles
Copy link
Contributor Author

Done! Please check now

@rcaselles rcaselles requested a review from paperdave May 4, 2024 10:35
Copy link

github-actions bot commented May 7, 2024

@rcaselles, your commit has failing tests :(

💪 3 failing tests Darwin AARCH64

💻 1 failing tests Darwin x64 baseline

💻 3 failing tests Darwin x64

🐧💪 2 failing tests Linux AARCH64

🐧🖥 1 failing tests Linux x64

🪟💻 16 failing tests Windows x64 baseline

🪟💻 7 failing tests Windows x64

View logs

@paperdave paperdave merged commit c4fa1e3 into oven-sh:main May 7, 2024
38 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

confirm() is never true on Windows
2 participants