support onread in net #10753
Merged
support onread in net #10753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/js/node/net.ts
Outdated
| @@ -100,6 +100,11 @@ const Socket = (function (InternalSocket) { | |||
| data({ data: self }, buffer) { | |||
| if (!self) return; | |||
|
|
|||
| if (self.#onreadCallback) { | |||
There was a problem hiding this comment.
Suggested change
| if (self.#onreadCallback) { | |
| const onReadCallback = self.#onreadCallback; | |
| if (onReadCallback) { | |
| try { | |
| onReadCallback(buffer.length, buffer); | |
| } catch(e) { | |
| self.emit("error", e); | |
| } | |
| return; | |
| } |
There was a problem hiding this comment.
Ideally, we'd have a separate handlers object and not do this check here on every single call to onData
There was a problem hiding this comment.
Changed to use a separate handlers object
…into georgijs/net-onread
…into georgijs/net-onread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements support for the
onreadoption innode:netFixes #10719
How did you verify your code works?
Added a test