Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better stubs for perf_hooks.{createHistogram,monitorEventLoopDelay} #10702

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Electroid
Copy link
Contributor

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I added tests

Copy link

github-actions bot commented Apr 30, 2024

@Jarred-Sumner, your commit has failing tests :(

💪 4 failing tests Darwin AARCH64

💻 3 failing tests Darwin x64 baseline

💻 2 failing tests Darwin x64

🐧🖥 1 failing tests Linux x64

🪟💻 7 failing tests Windows x64 baseline

🪟💻 10 failing tests Windows x64

View logs

@gvilums
Copy link
Contributor

gvilums commented May 2, 2024

Is this PR ready for review or should the TODOs be addressed first? If so we should mark it as draft

@Electroid Electroid marked this pull request as draft May 2, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants