Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in Windows PipeReader #10674

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Fix crash in Windows PipeReader #10674

wants to merge 7 commits into from

Conversation

paperdave
Copy link
Collaborator

What does this PR do?

Fixes #10660, a crash impacting Next.js dev server while reading files.

To make better panics, I'm introducing two new functions:

  • unexpectedTag, for use in a switch else => |t| unexpectedTag
  • releaseNonNull, named after the method of the same name in WebKit's Ref. This is a release-mode safety checked version of .? and should be used if one is not confident

This fixes the test locally for me, but I don't think it will fix CI as CI was running into a different test failure.

@paperdave paperdave changed the title Fix PipeReader Fix crash in Windows PipeReader Apr 30, 2024
@paperdave paperdave marked this pull request as draft April 30, 2024 02:02
@paperdave
Copy link
Collaborator Author

Does not fix the crash

Copy link

@paperdave, your commit has failing tests :(

💪 2 failing tests Darwin AARCH64

💻 1 failing tests Darwin x64 baseline

💻 1 failing tests Darwin x64

🐧💪 3 failing tests Linux AARCH64

🐧🖥 3 failing tests Linux x64 baseline

🐧🖥 1 failing tests Linux x64

🪟💻 8 failing tests Windows x64 baseline

🪟💻 10 failing tests Windows x64

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch in next.js with --bun flag
1 participant