Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

confirm() is never true on Windows #10643

Closed
infrahead opened this issue Apr 29, 2024 · 2 comments · Fixed by #10802
Closed

confirm() is never true on Windows #10643

infrahead opened this issue Apr 29, 2024 · 2 comments · Fixed by #10802
Labels
bug Something isn't working good first issue Something that would be good for new contributors windows An issue that only occurs on Windows

Comments

@infrahead
Copy link

What version of Bun is running?

1.1.6+e58d67b46

What platform is your computer?

Microsoft Windows NT 10.0.22631.0 x64

What steps can reproduce the bug?

Ran into same thing I reported previously on Linux... #5985

What is the expected behavior?

returns true for y

What do you see instead?

is always false, regardless of value

Additional information

It does work (was fixed) on Linux
@infrahead infrahead added the bug Something isn't working label Apr 29, 2024
@paperdave paperdave added the windows An issue that only occurs on Windows label Apr 30, 2024
@paperdave
Copy link
Collaborator

without investigating, i am almost certain this is because a \r is included on the read data.

@paperdave paperdave added the good first issue Something that would be good for new contributors label Apr 30, 2024
@ADTmux
Copy link

ADTmux commented Apr 30, 2024

Hi, I would like to work on this!

@rcaselles rcaselles mentioned this issue May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Something that would be good for new contributors windows An issue that only occurs on Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix confirm is never true in windows rcaselles/bun
3 participants
@infrahead @paperdave @ADTmux