Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support messages having a part attribute without namespace prefix #570

Conversation

driesva
Copy link
Contributor

@driesva driesva commented May 14, 2024

  • Function to resolve the targetNamespace from the WSDL-document. If such a target namespace is declared and e.g. the element attribute of the message part has no namespace prefix, use that target namespace to construct a qualified name.
  • Adapt random test WSDLs to have no namespace prefix

fixes #569

@outofcoffee outofcoffee self-requested a review May 18, 2024 17:55
driesva and others added 2 commits May 18, 2024 20:04
* Function to resolve the targetNamespace from the WSDL-document. If such a target namespace is declared and e.g. the element attribute of the message part has no namespace prefix, use that target namespace to construct a qualified name.
* Adapt random test WSDLs to have no namespace prefix

fixes outofcoffee#569
@outofcoffee outofcoffee force-pushed the fix/support-message-part-element-without-ns-prefix-if-target-namespace-is-declared branch from 34f4502 to 478c935 Compare May 18, 2024 19:48
@outofcoffee outofcoffee changed the base branch from main to develop May 18, 2024 19:48
Copy link
Owner

@outofcoffee outofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this! LGTM

@outofcoffee outofcoffee merged commit a2c7e02 into outofcoffee:develop May 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SOAP: WSDL with targetNamespace and messages without namespace prefix parsing issue
2 participants