Add tokenizer to cache key #876
Open
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 7, 2024
brandonwillard
requested changes
May 8, 2024
| elif hasattr(tokenizer, "path"): | ||
| tokenizer.name_or_path = tokenizer.path | ||
| else: | ||
| print("[WARNING]: tokenizer has no name or path. Setting cache key to `unknown`") |
| @@ -52,6 +52,17 @@ def adapt_tokenizer(tokenizer: PreTrainedTokenizerBase) -> PreTrainedTokenizerBa | |||
| tokenizer.vocabulary = tokenizer.get_vocab() | |||
| tokenizer.special_tokens = set(tokenizer.all_special_tokens) | |||
|
|
|||
| # tokenizer.name_or_path is one of the keys for `create_states_mapping()` cache | |||
| if hasattr(tokenizer, "name_or_path"): | |||
There was a problem hiding this comment.
To what do all these cases correspond? Regardless, we'll need tests for them.
|
@ekagra-ranjan, nice. Would an alternative be to devise a function that will compute a unique hash given the current class members? This would not require changing the API. |
Yes, that would be much better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #872