support webrtc-datachannel sdp exchange #3475
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johzzy
reviewed
Mar 17, 2023
winlinvip
force-pushed
the
develop
branch
3 times, most recently
from
c056094
to
2ac9eb8
Compare
Co-authored-by: john <[email protected]>
Co-authored-by: chundonglinlin <[email protected]> Co-authored-by: panda <[email protected]>
…ossrs#3427) * WHIP: Support DELETE resource. * Support push by Larix. * FLV: Disable stash buffer for realtime. * WHEP: Fix muted issue. ------- Co-authored-by: chundonglinlin <[email protected]> Co-authored-by: panda <[email protected]>
…meout. v5.0.149, v6.0.37 (ossrs#3455) Co-authored-by: winlin <[email protected]> Co-authored-by: ChenGH <[email protected]>
…#3477) Co-authored-by: winlin <[email protected]> Co-authored-by: john <[email protected]>
In dockerfile, we can set the default RTC candidate to env: ``` ENV SRS_RTC_SERVER_CANDIDATE=\$CANDIDATE CMD ["./objs/srs", "-e"] ``` When starts a docker container, user can setup the candidate by env: ``` docker run --rm -it --env CANDIDATE=1.2.3.4 ossrs/srs:5 ``` We should parse the content of SRS_RTC_SERVER_CANDIDATE as env variable name and parse it again. --------- Co-authored-by: chundonglinlin <[email protected]> Co-authored-by: pengfei.ma <[email protected]>
…ssrs#3450) Co-authored-by: winlin <[email protected]> Co-authored-by: ChenGH <[email protected]>
suzp1984
reviewed
Apr 17, 2023
| console.log('?api=x to overwrite WebRTC API(1985).'); | ||
| console.log('?schema=http|https to overwrite WebRTC API protocol.'); | ||
|
|
||
| var server = (!query.server)? window.location.hostname:query.server; |
There was a problem hiding this comment.
why not give ?a:b some spaces, ref line #131 'http:' ? '1985' : '1990'. They are so crowded, are they?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, SRS does not support WebRTC data channel. If a client requests to establish a data channel connection, it will cause an error in the browser.
The SDP response from SRS before modification is as follows:
After modification:
Doubtful:
Is datachannel considered as a media stream? Does it count as a track? If not, it should not be placed inside theSrsMediaDescclass, but should be separated.TRANS_BY_GPT3