model: Add resolved copyright source #5517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In German law, the author and the copyright holder can be two seperate legal entities and therefore also need to be treated separately. Introduce a new copyright holder field that is now the primary source for copyright holder information. Authors are still only used as copyright holders if the `addAuthorsToCopyrights` option is enabled. For now, all package manager implementations set empty copyright holders. Filling the copyright holder field is left as an exercise for future actions. Right now, the only way to add copyright holders is via curations. This change resolves oss-review-toolkit#4519. Signed-off-by: Rainer Bieniek <[email protected]>
This change refines the capability to determine the source of a copyright statement in the reporter stage. The fact that the German copyright laws separate between an author and a copyright holder influence the decision on wether a copyright statement is emitted in the final result or if it is suppressed due to its source This change introduces three different sources for a copyright statement: - Determined by the scanner - Provided by curation - Synthesized from the author Signed-off-by: Rainer Bieniek <[email protected]>
porsche-rbieniek
changed the title
porsche-rbieniek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an additional property to the resolved copyright finding to let reporter implementations know where a copyright statement originates from.
We have an use case in our reporter implementations where the output of a copyright statement is allowed only if
This change introduces a clear-cut property which allows reporter implementations to decide on a exact condition.
This pull request is blocked by #5504