Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: OrtConfiguration: Introduce connections map to centralize StorageConnections #5516

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bs-ondem
Copy link
Member

@bs-ondem bs-ondem commented Jul 4, 2022

Please ensure that your pull request adheres to our contribution guidelines. Thank you!

@bs-ondem bs-ondem changed the title OrtConfiguration: Introduce connections map for centralizing StorageConnections OrtConfiguration: Introduce connections map to centralize StorageConnections Jul 4, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #5516 (dd60abf) into main (26392e1) will decrease coverage by 0.18%.
The diff coverage is 11.90%.

@@             Coverage Diff              @@
##               main    #5516      +/-   ##
============================================
- Coverage     57.66%   57.47%   -0.19%     
  Complexity     2190     2190              
============================================
  Files           321      324       +3     
  Lines         18989    19059      +70     
  Branches       3730     3739       +9     
============================================
+ Hits          10950    10955       +5     
- Misses         6898     6964      +66     
+ Partials       1141     1140       -1     
Flag Coverage Δ
funTest-analyzer-docker 74.54% <0.00%> (ø)
funTest-non-analyzer 46.26% <0.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/kotlin/curation/Sw360PackageCurationProvider.kt 0.00% <0.00%> (ø)
cli/src/main/kotlin/commands/ScannerCommand.kt 35.54% <0.00%> (ø)
.../src/main/kotlin/config/HttpFileBasedConnection.kt 0.00% <0.00%> (ø)
...src/main/kotlin/config/LocalFileBasedConnection.kt 0.00% <0.00%> (ø)
...src/main/kotlin/config/ScanStorageConfiguration.kt 66.66% <0.00%> (-33.34%) ⬇️
model/src/main/kotlin/config/StorageConnection.kt 0.00% <0.00%> (ø)
scanner/src/main/kotlin/storages/Sw360Storage.kt 0.00% <0.00%> (ø)
...rc/main/kotlin/config/FileArchiverConfiguration.kt 38.09% <66.66%> (ø)
...el/src/main/kotlin/config/AnalyzerConfiguration.kt 89.74% <100.00%> (ø)
...in/kotlin/config/ProvenanceStorageConfiguration.kt 77.77% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bs-ondem bs-ondem changed the title OrtConfiguration: Introduce connections map to centralize StorageConnections WIP: OrtConfiguration: Introduce connections map to centralize StorageConnections Jul 4, 2022
@sschuberth
Copy link
Member

@bs-ondem, @mnonnenmacher, @MarcelBochtler, are there any plans to finish the work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants