Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am building a binary for OSX that reports the details of devices that are physically connected to the Mac.
I used your implementation of stringFromCFData in order to convert the "USB device signature" which is of type Data (bytes) into a string. However I saw that the output is a random unrelated string.
I created my own implementation and called both implementations one after the other in order to compare results:
Here are the results, screenshotted from my XCode debugging session:
On the left is an ioRegistryExplorer window showing the device "USB device signature", on the right are the results strings.
As you can see the current OSquery implementation is getting it wrong both times.
I even created a unit test locally in order to double check. This time I used a C-style byte array, as this is what "Data" really is.
As you can see the current implementation gets it wring again.