New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ComPtr<>
from the MS WRL library
#8014
base: master
Are you sure you want to change the base?
Conversation
608baf5
to
fdc6278
Compare
f3f2e7e
to
81f8797
Compare
The PR showcases Can you confirm that osquery operates without crashing and functions as expected upon exiting? You can test this by running osqueryi.exe, querying a table that utilizes the WMI functionality, and exiting the application. The Additionally, it would be great if you could explore the possibility of adding some tests to further illustrate the use of |
ComPtr<>
from the MS WRL library
@marcosd4h thanks for the review! Do you want to add tests into this particular PR or make a new one? |
I'll let you decide on this one. Having tests will help on showcasing more usage examples |
What's the status on this one? |
@directionless I should do some hand checks and I can try to add few unit-tests to show |
It's no problem leaving PRs open, but I'll push this to the next release target. |
@marcosd4h I would say that we have tests that run a query on each table on Windows, so this code should be already hit (for the concern of crashing), but more tests are welcome. That been said @dreamer-dead , I also wonder what about the notice reported here: https://learn.microsoft.com/en-us/cpp/cppcx/wrl/windows-runtime-cpp-template-library-wrl?view=msvc-160, which says that the WRL library is being deprecated in favor of the C++/WinRT one. I would move this to the next milestone though. |
Here I'm trying to use MS WRL library/component.
Relates to #8003
Will see how it builds/links