Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update restaurant.json - Added BBQ Plaza in Thailand #9455

Merged
merged 5 commits into from
May 13, 2024

Conversation

ckpiper
Copy link
Collaborator

@ckpiper ckpiper commented May 9, 2024

Now sure what to put for cuisine as about us page says food is grilled in a Mongolian and Japanase style. And not sure what was the decision from this #8884 conversation.

@1ec5
Copy link
Member

1ec5 commented May 10, 2024

The outcome of #6791 was to tag cuisine=mongolian_grill (though it should’ve been mongolian_barbecue). On the other hand, if this chain serves real Mongolian-style barbecue like they eat in Mongolia, then cuisine=barbecue;mongolian would be totally appropriate for this chain.

As for the Japanese part, you could append ;japanese, but it isn’t clear whether this is a reference to yakiniku or teppanyaki, which has a separate cuisine=teppanyaki tag already.

By the way, you’ll need to add some more statements to https://www.wikidata.org/wiki/Q125861684 to prevent it from getting deleted as meaningless spam. See this guide on the wiki for some tips.

@ckpiper
Copy link
Collaborator Author

ckpiper commented May 10, 2024

@1ec5 Appreciate the advice. I will add more to the page. From what I can tell it is barbecue from mongolian like Khorkhog style or barbecue japanese barbecue. Also they bring you the uncooked food and you cook it yourself. Thus, should self_service tag also be applied? It is not like you go up and grab food.

"locationSet": {"include": ["th"]},
"matchNames": [
"BBQ Plaza",
"Bar.B.Q Plaza"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NSI already recognizes these two spelling variants, because it strips punctuation and lowercases before comparing names.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood how Bar.B.Q Plaza will already be recognized without punctuation. But How is BBQ Plaza recognized? It would need to strip the "ar" in "Bar" as well.

],
"tags": {
"amenity": "restaurant",
"brand": "Bar-B-Q Plaza",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double-checking: does the Thailand OSM community expect the primary name to be in English or Thai? From news coverage, it seems like at least some locations primarily signpost the English name, but I couldn’t tell if that’s representative.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at locations in google street view. Most have the Engilsh version largely displayed, but the Thai version is also displayed as a header note or foot note above/below/next to the English. Thus I thought I should add both.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was just wondering which should be in the main name key. Sounds like it should be the English name.

],
"tags": {
"amenity": "restaurant",
"brand": "Bar-B-Q Plaza",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was just wondering which should be in the main name key. Sounds like it should be the English name.

@Cj-Malone Cj-Malone merged commit 37e996b into osmlab:main May 13, 2024
2 checks passed
@Cj-Malone
Copy link
Collaborator

Thank you. If anyone from the Thailand community has an opinion, we will be happy to change it.

@ckpiper ckpiper deleted the add_bbq_plaza_th branch May 13, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants