transitionEnd not defined, nasty bug #887
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not in a position to set up a full JS build chain for this kind of thing and make a perfect commit, so I've put this pull request through as more of a bug report so you can see what needs fixing. |
|
Also I wanted to note that contrary to https://www.osano.com/cookieconsent/documentation/javascript-api/ (which I understand may not represent the latest code in the Open Source repository), cookieconsent.hasTransition is not configurable in this code. |
|
I'm seeing the same issue reported by users of smartphone devices. The cookie dialog sits over links and buttons, so although they are visible, they are not selectable by the user. Would be great to see this resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasTransition is defined in the object, but transitionEnd is not.
This is a regression from previous behavior.
What this causes is the cookie dialog to disappear to opacity:0 but remain active in the DOM. It steals focus from anything under it, including form buttons.