Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(programmatic): cleanup useProgrammatic composable #833

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Mar 2, 2024

Part of #829
Fixes #828

Proposed Changes

  • cleanup useProgrammatic composable
  • update useClickOutside and useEventListener composables
  • remove unnecessary properties

@mlmoravek mlmoravek added breaking Breaking changes refactoring This involves some refactoring of existing code. labels Mar 2, 2024
Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit eaf3aa3
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/66322a6b8c3dab0008775f4e
😎 Deploy Preview https://deploy-preview-833--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 140 lines in your changes are missing coverage. Please review.

Project coverage is 0.20%. Comparing base (484cfe8) to head (1cc8b59).
Report is 64 commits behind head on develop.

❗ Current head 1cc8b59 differs from pull request most recent head eaf3aa3. Consider uploading reports for the commit eaf3aa3 to get more accurate results

Files Patch % Lines
packages/oruga/src/components/modal/Modal.vue 0.00% 20 Missing and 13 partials ⚠️
packages/oruga/src/components/sidebar/Sidebar.vue 0.00% 20 Missing and 12 partials ⚠️
packages/oruga/src/composables/useProgrammatic.ts 0.00% 17 Missing and 12 partials ⚠️
packages/oruga/src/composables/useEventListener.ts 0.00% 14 Missing and 5 partials ⚠️
packages/oruga/src/components/loading/Loading.vue 0.00% 8 Missing and 4 partials ⚠️
...src/components/notification/NotificationNotice.vue 0.00% 6 Missing and 4 partials ⚠️
packages/oruga/src/composables/useClickOutside.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #833       +/-   ##
===========================================
- Coverage    56.71%   0.20%   -56.52%     
===========================================
  Files           30     108       +78     
  Lines         1511    5309     +3798     
  Branches       544    1933     +1389     
===========================================
- Hits           857      11      -846     
- Misses         654    4169     +3515     
- Partials         0    1129     +1129     
Flag Coverage Δ
oruga-next 0.20% <0.00%> (-56.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek changed the title refactor(programmatic): cleanup useProgrammatic composable refactor(programmatic): cleanup useProgrammatic composable Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript error : Type 'HTMLElement | null' is not assignable to type 'string | HTMLElement | undefined'.
1 participant