Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance a11y #762

Merged
merged 4 commits into from
Feb 6, 2024
Merged

feat: enhance a11y #762

merged 4 commits into from
Feb 6, 2024

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Feb 6, 2024

Part of #596
Fixes #455
Fixes #446

Proposed Changes

  • Add several addional handler for a11y purpose
  • Add several tabindex and role properties for a11y
  • Change DatepickerMonth & DatepickerTableRow a tag to div
  • Fix Steps generic component child item
  • Change Steps nav item markup to ol/li
  • Small code refactorings

@mlmoravek mlmoravek added the a11y Accessibility label Feb 6, 2024
@mlmoravek mlmoravek self-assigned this Feb 6, 2024
Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 4d4ce5c
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/65c1f3767df87800086d90a0
😎 Deploy Preview https://deploy-preview-762--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (796ed9f) 54.25% compared to head (4d4ce5c) 54.25%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #762   +/-   ##
========================================
  Coverage    54.25%   54.25%           
========================================
  Files           32       32           
  Lines         1480     1480           
  Branches       527      527           
========================================
  Hits           803      803           
  Misses         677      677           
Flag Coverage Δ
oruga-next 54.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek requested a review from jtommy February 6, 2024 09:43
@mlmoravek mlmoravek merged commit 41b1c54 into oruga-ui:develop Feb 6, 2024
9 checks passed
@mlmoravek mlmoravek deleted the enhance-a11y branch February 6, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Step link needs an href attribute so that it's keyboard navigable Tab Component: Improve Accessibility
2 participants