Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fixed QT deprecation warnings #8177

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[WIP] Fixed QT deprecation warnings #8177

wants to merge 1 commit into from
+18 −27

Conversation

biodranik
Copy link
Member

No description provided.

@biodranik biodranik requested a review from vng May 14, 2024 21:27
@biodranik biodranik changed the title Ab qt deprecation fix Fixed QT deprecation warnings May 14, 2024
@biodranik
[qt] Fixed deprecation warnings
786423a 
Signed-off-by: Alexander Borsuk <[email protected]>
@vng
Copy link
Member

vng commented May 14, 2024

Did you compile your changes? :)

@biodranik
Copy link
Member Author

Yes, but there are older QT versions everywhere, including Github CI :( So our options are:

  1. Require at least QT version 6.4
  2. Silence this warning locally with pragma
  3. Silence this warning globally for whole qt project
  4. Rewrite the code without a warning but with more lines of code/a bit uglier way.

@biodranik biodranik changed the title Fixed QT deprecation warnings [WIP] Fixed QT deprecation warnings May 16, 2024
@biodranik biodranik marked this pull request as draft May 16, 2024 22:27
@Ferenc-
Copy link
Contributor

Ferenc- commented May 21, 2024

older QT versions everywhere, including Github CI

Since #8193 the CI has Qt 6.4.2, so you could consider a rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vng vng vng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@biodranik @vng @Ferenc-