-
-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android] Add possibility to select bookmark category after long click on Save button #8166
base: master
Are you sure you want to change the base?
[android] Add possibility to select bookmark category after long click on Save button #8166
Conversation
…button Signed-off-by: Kiryl Razhdzestvenski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UX and the code do not look right...
Would it be better and easier to immediately show an existing "Edit bookmark" dialog when a bookmark was added using a long tap?
I think it will be a little less convenient. User will go through several screens to complete the target action. |
Signed-off-by: Kiryl Razhdzestvenski <[email protected]>
Signed-off-by: Kiryl Razhdzestvenski <[email protected]>
Did as you said) |
Its an improvement over the current UX indeed. However the solution described in #1060 (comment) brings it down to just 1 long tap + 1 tap. Much better! There are other ideas how to edit name / description quickly: |
I have already implemented the solution that @biodranik suggested.
|
Did anyone else test it? @Jean-BaptisteC WDYT? |
It's better to add also listener when poi is already in bookmarks. To move poi in another bookmark list without need to open place page. |
Sorry, can you explain in more detail, what do you mean? Perfectly - step-by-step) |
@Jean-BaptisteC, I did it on purpose, and I think it's the correct behavior. Long-pressing initiates the bookmark creation process. When POI is already in the bookmark list, the button behavior changes to 'remove,' and we don't need to show the 'create' window. |
The main UX question is: should long-tap behavior be consistent and always show the create/edit bookmark dialog, or should it behave differently if a place is bookmarked or not bookmarked? In the former case, it duplicates the "Edit Bookmark" button functionality but is more consistent and easier to use. In the latter case, it may be an unexpected behavior and lead to bookmark deletion. |
The first solution seems more logical to me. We click on the “Create” button, the bookmark creation dialog is called up and the bookmark is created. In any case, if will be feedback that the behavior is not obvious (when implementing the first solution), the behavior can be modified with one line of code) |
IMO long tapping on a delete button resulting in the edit dialog is unexpected, inconsistent and confusing. Though otherwise its safe and users who get accustomed to this strange behaviour may use it for their advantage.. Still it feels weird and I'd rather avoid such controversial UX patterns (i.e. leave the long tap on delete button do nothing). |
In addition, I think that most users (not developers) may well perceive this button as 2 different buttons (because they have different names). And don't expect the same behavior from them. |
Added features
After long click on Save bookmark button we can edit bookmark before if will be added.
By default, a new bookmark is initiated with parameters (name, icon, etc.) as for quick creation in current logic.
Issues
#1060 (comment)
#6234
#5512