-
-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ios] Basic support for CarPlay/phone mode switch #8130
[ios] Basic support for CarPlay/phone mode switch #8130
Conversation
Wow, this is cool. @kirylkaveryn and I discussed that we want to start working on this feature just a few days ago. Thanks for contributing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
@kirylkaveryn @fabwu can you please review and test if it works on your devices?
This is great! Let me test this on my device and I'll give you feedback. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabwu @AndrewShkrob thanks for pointing out about scale issue. |
Thanks to everyone who participated! Is it ready for test/review/merge? |
4b51ab2
to
a966bbc
Compare
@biodranik I have a few questions (see threads), but in general did everything planned and waiting for review. |
This comment was marked as resolved.
This comment was marked as resolved.
@fabwu, thank you for one more report! Should be fixed now. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested these changes in my car and the switch works even within a navigation session. I can't help with the layout of the button so I have no more things to add here.
b13e482
to
daca7bd
Compare
Signed-off-by: Oleg Montak <[email protected]>
Signed-off-by: Oleg Montak <[email protected]>
daca7bd
to
5dd02e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is a critical fix for many users, me included ) Thanks to everyone for implementing, testing and reviewing the PR. It is a great example of team work and the power of the community! I'm sooo happy to see it, and very grateful for your time spent on it ❤️ 🙏 🚀
Allow using OrganicMaps on iPhone while connected to CarPlay, see quick demo here – #763 (comment)
This is naive approach with just calling the code that usually get called on CarPlay connect/disconnect events, at first glance it works fine, but help with testing is welcome.
Resolves #763
Strings translation note:
I added new string
carplay_continue_on_the_phone
with translations from DeepL.Also I copy-pasted
carplay_used_on_the_phone_screen
andcarplay_continue_in_the_car
from Android Auto as is, they don't need translation.