Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list.rs to include inscription and rune info #3766

Merged
merged 16 commits into from
May 24, 2024

Conversation

cryptoni9n
Copy link
Collaborator

fixes #3701 - I've added the /output/<OUTPOINT> fields to the ord list command into a section called "list'. I also reordered the fields in the pre-existing "ranges" section to make more logical sense. There is a small amount of redundancy now with the list.sat_ranges vs ranges.start & end, and list.value vs ranges.size. I figure that this is acceptable and better than changing the pre-existing ranges section, as some users may already be reliant upon those fields - but let me know if not and if further formatting or changes would be better.

cryptoni9n and others added 7 commits May 18, 2024 11:49
fixes ordinals#3701 - I've added the /output/<OUTPOINT> fields to the `ord list` command into a section called 'list'.  I also reordered the fields in the existing 'ranges' section to make more logical sense.  There is a small amount of redundancy now with the list.sat_ranges vs ranges.start & end, and list.value vs ranges.size.
@cryptoni9n cryptoni9n requested a review from raphjaph May 20, 2024 21:49
src/subcommand/list.rs Outdated Show resolved Hide resolved
src/subcommand/list.rs Outdated Show resolved Hide resolved
tests/list.rs Outdated Show resolved Hide resolved
tests/list.rs Outdated Show resolved Hide resolved
cryptoni9n and others added 5 commits May 23, 2024 14:04
removing comment

Co-authored-by: raph <[email protected]>
removing comment

Co-authored-by: raph <[email protected]>
removing comment

Co-authored-by: raph <[email protected]>
removing comment

Co-authored-by: raph <[email protected]>
Copy link
Collaborator Author

@cryptoni9n cryptoni9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all suggestions committed; comments removed

@cryptoni9n cryptoni9n requested a review from raphjaph May 24, 2024 13:37
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphjaph raphjaph enabled auto-merge (squash) May 24, 2024 15:39
@raphjaph raphjaph merged commit b0a26e2 into ordinals:master May 24, 2024
5 checks passed
@cryptoni9n cryptoni9n deleted the feature-branch branch May 24, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ord list <UTXO> won't list inscriptions and runes
2 participants