Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination for runes and fix size query #3602

Closed

Conversation

lugondev
Copy link
Contributor

No description provided.

@raphjaph
Copy link
Collaborator

raphjaph commented May 6, 2024

We've made the default 100 for DoS protection reasons. Specifying the query size would circumvent that protection. So unfortunately I cannot merge this.

What's wrong with making multiple requests until you reach the amount you want?

@lugondev
Copy link
Contributor Author

We've made the default 100 for DoS protection reasons. Specifying the query size would circumvent that protection. So unfortunately I cannot merge this.

What's wrong with making multiple requests until you reach the amount you want?

yeah, we can disable page size for query to prevent DoS.
currently, I return wrong page size. 51 per page (now size is 50).
I will make default is 100.

@raphjaph
Copy link
Collaborator

raphjaph commented Jun 8, 2024

I don't think we should allow this since this circumvents the DoS protection. If you want more than 100 runes then it's best to just make multiple requests.

@raphjaph raphjaph closed this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants