add --no-wait flag to not wait for etching to mature #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rot13maxi C-c? |
|
control-c |
twosatsmaxi
suggested changes
Apr 12, 2024
| ) -> Result<batch::Output> { | ||
| eprintln!("Waiting for rune commitment {} to mature…", commit.txid()); | ||
|
|
||
| self.save_etching(rune, &commit, &reveal, output.clone())?; | ||
|
|
||
| loop { | ||
| if SHUTTING_DOWN.load(atomic::Ordering::Relaxed) { | ||
| if SHUTTING_DOWN.load(atomic::Ordering::Relaxed) || no_wait { |
There was a problem hiding this comment.
why not instead have a separate message for no_wait instead of combining it with suspending batch.... message, else branch saying "commitment submiited, reveal is pending" something along that line.
rot13maxi
force-pushed
the
no-wait-runes
branch
from
f87a1dc
to
a635265
Compare
casey
requested changes
Apr 17, 2024
|
This is a good feature, any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you're going to C-c anyway, you can instead pass the
--no-waitflag when you do an etching. Makes it easier to wrap this in a script, if you're into such degeneracy.not in love with the way this gets passed through, so marking it a draft for now.