Add type hints to auth server app #1216
Conversation
|
🚀 Awesome! Thanks for opening this pull request, it is great to see that you don't mind getting your hands dirty. |
|
|
…t into auth-server-type-hints * 'auth-server-type-hints' of github.com:sbarrios93/orchest: dont load _typeshed module at runtime add types to utils.py and views.py on auth-server Bump patch on version Improve retry message
There was a problem hiding this comment.
Thanks for your contribution @sbarrios93! 🎉 I did not do an in-depth review, just left one comment about type union syntax, I think we can upgrade it even if Orchest runs (for now) on Python 3.8.
|
Thank you for the contribution @sbarrios93 😎! |
yannickperrenet
added
the
internal
Happy to help! Looking forward to keep helping this project grow |
|
Opened an issue about verifying these static types as part of our CI #1222 |
Opted to use `typing.Union` still where linebreaks would be needed. Line
breaks using the new `|` syntax is pretty horrible, e.g.:
```python
def foo() -> Tuple[
int, str
] | Tuple[str, str]:
pass
```
In my opinion the above is much harder to read then:
```python
def foo() -> Union[
Tuple[int, str],
Tuple[str, str],
]:
pass
```
|
Thanks for getting this started @sbarrios93! We took the liberty of finishing it :) |
Description
Added type hints to auth server app on modules
services/auth-server/app/app/views.pyandservices/auth-server/app/app/utils.pyRelated to: #450
Checklist
devinstead ofmaster.requirements.inI have runpip-compileto update the correspondingrequirements.txt.models.pyI have performed the appropriate database migrations (refer to the DB migration docs).orchest-sdkI followed its release checklist.orchest-cliI followed its release checklist.