Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to use only precomputed point predictions #4

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

FlorentRamb
Copy link

This PR adds the ability to train and use a macest model only from precomputed point predictions. This allows to have no reference to the point predcition model in the macest model, which makes the loading/saving and usage of these models easier. The following changes are introduced:

  • the model or point_pred_model argument in __init__ becomes optional
  • an optional parameter prec_point_preds is added to ModelWithConfidence.fit, ModelWithConfidence.predict_confidence_of_point_prediction, ModelWithPredictionInterval.predict_interval and ModelWithPredictionInterval.fit
  • an optional parameter update_empirical_conflict_constant is added to _TrainingHelper.fit. It allows to skip the step find_conflicting_predictions

Signed-off-by: Florent Rambaud [email protected]

@rgreen1995
Copy link

Hi, @FlorentRamb great to see you working on this and improving the code! just to check how this works, is this allowing you to do a similar pre-computation in prediction as we do when training the model? i.e. when training we calculate the point predictions once at the beginning and then pass these predictions around when training all the mace parameters. So is this MR allowing you to do this after training?

@FlorentRamb
Copy link
Author

If I'm understanding well, yes indeed! The optional parameter prec_point_preds is added to ModelWithConfidence.predict_confidence_of_point_prediction and ModelWithPredictionInterval.predict_interval. Using it allows you to pre-compute the point predictions of your ml model and then feed them to the macest model even at prediction time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants