Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding OHS 12.2.1.4 dockerfiles and removing 12.2.1.3 which is no lon… #2796

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adding OHS 12.2.1.4 dockerfiles and removing 12.2.1.3 which is no lon… #2796

wants to merge 4 commits into from

Conversation

mriccell
Copy link
Member

@mriccell mriccell commented May 7, 2024

Adding OHS 12.2.1.4 dockerfiles and removing 12.2.1.3 which is no longer supported.
Making changes container-scripts so that things like the Domain_HOME come from the environment variable.
Create 12.2.1.4 sample for patching

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 7, 2024
@mriccell mriccell requested a review from rjeberhard May 7, 2024 19:26
rjeberhard
rjeberhard previously approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@rjeberhard rjeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving... a few comments on copyrights (of course!) and a suggestion to look at each usage of the word "Docker" to see if it can be made generic for any container environment.

mriccell
mriccell commented Jun 10, 2024
View reviewed changes
Copy link
Member Author

@mriccell mriccell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed all comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjeberhard rjeberhard rjeberhard left review comments

@Prabhat-Kishore Prabhat-Kishore Awaiting requested review from Prabhat-Kishore Prabhat-Kishore is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mriccell @rjeberhard