Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle experimental feature warning #5434

Merged

Conversation

nabenabe0928
Copy link
Collaborator

Motivation

As experimental feature warning scattered around the codebase, I bundled them in a single place.

Description of the changes

I simply created a function to warn experimental features and use them for every single line.

@nabenabe0928 nabenabe0928 force-pushed the code-fix/use-experimental-template branch from 64dfe9e to 55e1036 Compare May 8, 2024 04:12
@nabenabe0928
Copy link
Collaborator Author

@eukaryo @not522 Could you review this PR?

Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using argument instead of option? I feel a bit odd to call some of the features option.

Co-authored-by: Naoto Mizuno <[email protected]>
@nabenabe0928 nabenabe0928 force-pushed the code-fix/use-experimental-template branch from c219aec to c4de828 Compare May 15, 2024 05:11
Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@not522 not522 removed their assignment May 20, 2024
Copy link
Collaborator

@eukaryo eukaryo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eukaryo eukaryo added the code-fix Change that does not change the behavior, such as code refactoring. label May 22, 2024
@eukaryo eukaryo added this to the v4.0.0 milestone May 22, 2024
@eukaryo eukaryo removed their assignment May 22, 2024
@eukaryo eukaryo merged commit 1a2dfd4 into optuna:master May 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-fix Change that does not change the behavior, such as code refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants