wireguard: update dialogEditWireguardClient.xml for minor spelling mistake #7420
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fichtner
reviewed
Apr 30, 2024
| @@ -29,7 +29,7 @@ | |||
| <style>tokenize</style> | |||
| <type>select_multiple</type> | |||
| <allownew>true</allownew> | |||
| <help>List of networks allowed to pass trough the tunnel adapter. Use CIDR notation like 10.0.0.0/24.</help> | |||
| <help>List of networks allowed to pass through the tunnel adapter. Use CIDR notation like 10.0.0.0/24.</help> | |||
There was a problem hiding this comment.
If we are here can we do this?
Suggested change
| <help>List of networks allowed to pass through the tunnel adapter. Use CIDR notation like 10.0.0.0/24.</help> | |
| <help>List of networks to route through the tunnel adapter. Use CIDR notation like 10.0.0.0/24.</help> |
There was a problem hiding this comment.
it's pass and route when "Disable routes" is unchecked, otherwise it's only pass
There was a problem hiding this comment.
Ok, my main motivation is to get rid of explaining „allowed“ terminology with „allowed“ in the description.
There was a problem hiding this comment.
It's a bit confusing indeed, maybe better to only explain the type of expected input, something like:
Use CIDR notation like 10.0.0.0/24, when routes are enabled one will be added for this network as well.
AdSchellevis
force-pushed
the
master
branch
3 times, most recently
from
78845fc
to
8ba454a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.