Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WAFD] res_tenant fix in resource/opentelekomcloud_waf_dedicated_instance_v1 #2497

Merged
merged 2 commits into from
May 3, 2024
Merged

[WAFD] res_tenant fix in resource/opentelekomcloud_waf_dedicated_instance_v1 #2497

merged 2 commits into from
May 3, 2024

Conversation

anton-sidelnikov
Copy link
Member

@anton-sidelnikov anton-sidelnikov commented May 2, 2024 •
edited
Loading

Summary of the Pull Request

Now possible to set res_tenant attribute on create

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccWafDedicatedInstanceV1_basic
--- PASS: TestAccWafDedicatedInstanceV1_basic (379.55s)
=== RUN   TestAccWafDedicatedInstanceV1_basic
--- PASS: TestAccWafDedicatedInstanceV1_basic (380.92s)
PASS

Process finished with exit code 0

@anton-sidelnikov anton-sidelnikov self-assigned this May 2, 2024
@anton-sidelnikov anton-sidelnikov added the gate Merge PR label May 3, 2024
@otc-zuul otc-zuul
Copy link

otc-zuul bot commented May 3, 2024

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/b15717ab334747e687e3ee8619719285

✔️ build-otc-releasenotes SUCCESS in 6m 38s
✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 3m 09s
✔️ golang-make-test SUCCESS in 4m 40s
✔️ golang-make-vet SUCCESS in 4m 04s
✔️ tflint SUCCESS in 2m 48s
✔️ goreleaser-build SUCCESS in 8m 40s

@otc-zuul otc-zuul bot merged commit e9ad626 into devel May 3, 2024
3 checks passed
@otc-zuul otc-zuul bot deleted the wafd-instance-res-tenant-fix branch May 3, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aloento Aloento Aloento approved these changes

@Persimmonboy Persimmonboy Awaiting requested review from Persimmonboy

@sgmv sgmv Awaiting requested review from sgmv

@vladimirvshivkov vladimirvshivkov Awaiting requested review from vladimirvshivkov

@artem-lifshits artem-lifshits Awaiting requested review from artem-lifshits

Assignees

@anton-sidelnikov anton-sidelnikov

Labels
bug documentation gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anton-sidelnikov @Aloento