Replace secondary actions nav with tag badge on trace list pages #4743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier I copied some of the navigation elements from traces traces to blocks:
Now I want to copy in the opposite direction. Individual block pages have navigation tabs, while individual trace pages don't:
So I want to take the navigation from trace lists and put it also on individual trace pages:
Here's a problem: the phrase "Browse recent GPS trace uploads" won't make sense on a single trace page. Let's suppose I remove this phrase. Then there's going to be just the "Remove Tag Filter" link if the filter is enabled. I tried to find a better place for this link, but it didn't fit next to tabs or rss/upload buttons.
But the tag is already mentioned in the heading. Maybe I can place the remove link there? That's what I did in this PR, with link turned into the x button:
