Center the nav links vertically #4723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhughes
reviewed
Apr 26, 2024
There was a problem hiding this comment.
The vertical alignment looks much better which is great but at least in Firefox the horizontal spacing between the items is reduced - the cause seems to be that previously the DOM put a whitespace item between each list item and that is gone with the flex layout.
Adding a one pixel margin on the list item seems to get it back to roughly where it was before but maybe there's a better solution or maybe people think the reduced spacing is ok?
|
This shouldn't be required with #4828 merged. |
|
That's very true. Thanks for the work @lectrician1 but I think this has been resolved by #4828 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #3372