Set maximum size limits for user provided content #4694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmd-osm
changed the title
|
Error message when trying to add a comment that is too long: |
|
For some reason, the three limits for comments don't seem to work yet. I don't get the error message above, instead the comment is simply discarded. I need to double check how this was done for note comments, where this is working as expected. The textarea has a maxlength="..." attribute that's probably missing here. -> now added! This should really behave like on the profile page:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe we should continue adding some upper size limits for various input fields, like we already do for note comments.
Limits in this pull request are a best guess only, and I'm open to make them larger if needed. However, they shouldn't be unlimited as they are today.
I'm aware that there are existing limits imposed by the web server, but I find them too large for input fields.