Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMP: add support for requesting certReqTemplate using genm/genp #24409

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

CMP: add support for requesting certReqTemplate using genm/genp #24409

wants to merge 4 commits into from

Conversation

rajeev-0
Copy link
Contributor

This pull request adds the ability to retrieve a certificate request template in the CMP client, following the guidelines outlined in section 4.3.3 of RFC 9483.

To request the certificate request template, the CMP client can send a genm message with the -infotype certReqTemplate option. The server will respond with a genp message containing the CertTemplate and optionally the keySpec, using the
id-it-certReqTemplate. The client can then save the CertTemplate and KeySpec in a specified file using the -template and -keyspec parameters, respectively.

Checklist
  • documentation is added or updated
  • tests are added or updated

@rajeev-0 rajeev-0 changed the title CMP: add support for requesting cert template using genm/genp CMP: add support for requesting certificate request template using genm/genp May 15, 2024
@rajeev-0 rajeev-0 changed the title CMP: add support for requesting certificate request template using genm/genp CMP: add support for requesting certReqTemplate using genm/genp May 15, 2024
@github-actions github-actions bot added the severity: ABI change This pull request contains ABI changes label May 15, 2024
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: feature The issue/pr requests/adds a feature tests: present The PR has suitable tests present labels May 15, 2024
@t8m
Copy link
Member

t8m commented May 15, 2024

CI is relevant

@rajeev-0 rajeev-0 force-pushed the CMP_add_CertReqTemplate branch 2 times, most recently from 473fc39 to 28621be Compare May 15, 2024 13:15
@rajeev-0 rajeev-0 closed this May 15, 2024
@rajeev-0
Copy link
Contributor Author

I closed it by mistake, I will reopen the pull request.
I will move it to draft mode to fix all the CI issues.

@rajeev-0 rajeev-0 reopened this May 15, 2024
@rajeev-0 rajeev-0 marked this pull request as draft May 15, 2024 13:20
@rajeev-0 rajeev-0 marked this pull request as ready for review May 15, 2024 14:54
MoazzemHossain-bot
MoazzemHossain-bot approved these changes May 15, 2024
View reviewed changes
Copy link

@MoazzemHossain-bot MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

DDvO
DDvO requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@DDvO DDvO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.
Looks generally pretty good.
Yet a number of small issues.

crypto/cmp/cmp_asn.c Outdated Show resolved Hide resolved
crypto/cmp/cmp_asn.c Outdated Show resolved Hide resolved
crypto/cmp/cmp_asn.c Outdated Show resolved Hide resolved
crypto/cmp/cmp_asn.c Outdated Show resolved Hide resolved
crypto/cmp/cmp_asn.c Outdated Show resolved Hide resolved
doc/man1/openssl-cmp.pod.in Outdated Show resolved Hide resolved
doc/man3/OSSL_CRMF_MSG_get0_tmpl.pod Outdated Show resolved Hide resolved
test/recipes/80-test_cmp_http_data/test_commands.csv Outdated Show resolved Hide resolved
test/recipes/80-test_cmp_http_data/test_commands.csv Outdated Show resolved Hide resolved
util/other.syms Outdated Show resolved Hide resolved
DDvO
DDvO requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@DDvO DDvO left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to be adapted further.

For this reason, a couple of issues above not yet marked resolved.

apps/cmp.c Outdated Show resolved Hide resolved
crypto/cmp/cmp_asn.c Outdated Show resolved Hide resolved
crypto/cmp/cmp_asn.c Outdated Show resolved Hide resolved
doc/man3/OSSL_CMP_ATAV_set0.pod Outdated Show resolved Hide resolved
apps/lib/cmp_mock_srv.c Outdated Show resolved Hide resolved
apps/cmp.c Show resolved Hide resolved
@rajeev-0 rajeev-0 requested a review from DDvO May 17, 2024 09:01
DDvO
DDvO requested changes May 17, 2024
View reviewed changes
test/recipes/80-test_cmp_http_data/test_commands.csv Outdated Show resolved Hide resolved
apps/lib/cmp_mock_srv.c Outdated Show resolved Hide resolved
crypto/cmp/cmp_asn.c Show resolved Hide resolved
MoazzemHossain-bot

This comment was marked as spam.

Sign in to view

DDvO
DDvO approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@DDvO DDvO left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine now, thanks for the swift fixes

@DDvO DDvO removed the approval: review pending This pull request needs review by a committer label May 17, 2024
@DDvO DDvO requested a review from t8m May 27, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DDvO DDvO DDvO approved these changes

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel Moazzem-Hossain-pixel approved these changes

@MoazzemHossain-bot MoazzemHossain-bot MoazzemHossain-bot approved these changes

@t8m t8m Awaiting requested review from t8m

Assignees
No one assigned
Labels
approval: otc review pending This pull request needs review by an OTC member branch: master Merge to master branch severity: ABI change This pull request contains ABI changes tests: present The PR has suitable tests present triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rajeev-0 @t8m @DDvO @Moazzem-Hossain-pixel @MoazzemHossain-bot