[release-4.15] OCPBUGS-33875: Use kubelet-ca.crt from ControllerConfig when certs rotate #2175
Conversation
This commit changes how WMCO determines the expected state of the kubelet-ca.crt file on Windows nodes. The previous functionality had WMCO using the kubelet-ca.crt file present in the worker MachineConfig as the initial state. When WMCO reconciles the ConfigMap containing the kube-apiserver-to-kubelet-client-ca, WMCO would then replace the kubelet-ca.crt file with a combination of the clusters initial kube-apiserver-to-kubelet-client-ca and the latest version. With this commit, when the CA is changed in the cluster, WMCO will instead look at the machine-config-controller ControllerConfig for the new version of the kubelet-ca.crt. This way WMCO is consistent in how it is sourcing the expected state with Linux Nodes, as the Machine Config Daemon does the same. This stops WMCO from repeating work that is already being done, and also ensures that we are including any other certs that should be present within kubelet-ca.crt.
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-22237 has been cloned as Jira Issue OCPBUGS-33875. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-33875, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
|
@mtnbikenc: This pull request references Jira Issue OCPBUGS-33875, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@sebsoto: This pull request references Jira Issue OCPBUGS-33875, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@sebsoto: This pull request references Jira Issue OCPBUGS-33875, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test remaining-required |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, sebsoto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 09c3894
into
openshift:release-4.15
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-33875: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-33875 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is an automated cherry-pick of #2167
/assign sebsoto
/cherrypick release-4.14 release-4.13 release-4.12