Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] bump vmtools image and auth keys for vSphere CI #2174

Merged
merged 3 commits into from
May 31, 2024

Conversation

jrvaldes
Copy link
Contributor

  • bump vmtools image to v1240
  • update pub auth keys with openshift shared pub key

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2024
Copy link
Contributor

openshift-ci bot commented May 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jrvaldes jrvaldes force-pushed the update-ci-docs branch 2 times, most recently from 26279d8 to feb88bb Compare May 14, 2024 19:58
This commit updates the authorized_keys file for the golden image
provisioning so that it matches with the private key used in development
and in CI jobs.
This commit updates the reference to the vmtools iso location so that it uses
a newer compatible version.
This commit removes the outdated example of the vmtools iso path and documents
the download page along with a valid example for the given datastore in
DEVQE datacenter.
@jrvaldes jrvaldes marked this pull request as ready for review May 14, 2024 19:59
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2024
Copy link
Contributor

@saifshaikh48 saifshaikh48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

though not sure if we should explicitly put the openshift-dev pub key in authorized_keys or rather just leave a note in the vsphere internal docs that openshift-dev was used/should be used in packer builds

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@jrvaldes
Copy link
Contributor Author

@mansikulkarni96 @sebsoto consider overriding the rest of the CI jobs in this PR.

@sebsoto
Copy link
Contributor

sebsoto commented May 15, 2024

/approve

@sebsoto
Copy link
Contributor

sebsoto commented May 15, 2024

/override ci/prow/aws-e2e-operator ci/prow/aws-e2e-upgrade ci/prow/azure-e2e-operator ci/prow/azure-e2e-upgrade ci/prow/gcp-e2e-operator ci/prow/nutanix-e2e-operator ci/prow/platform-none-vsphere-e2e-operator ci/prow/vsphere-proxy-e2e-operator ci/prow/wicd-unit-vsphere

Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
Copy link
Contributor

openshift-ci bot commented May 15, 2024

@sebsoto: Overrode contexts on behalf of sebsoto: ci/prow/aws-e2e-operator, ci/prow/aws-e2e-upgrade, ci/prow/azure-e2e-operator, ci/prow/azure-e2e-upgrade, ci/prow/gcp-e2e-operator, ci/prow/nutanix-e2e-operator, ci/prow/platform-none-vsphere-e2e-operator, ci/prow/vsphere-proxy-e2e-operator, ci/prow/wicd-unit-vsphere

In response to this:

/override ci/prow/aws-e2e-operator ci/prow/aws-e2e-upgrade ci/prow/azure-e2e-operator ci/prow/azure-e2e-upgrade ci/prow/gcp-e2e-operator ci/prow/nutanix-e2e-operator ci/prow/platform-none-vsphere-e2e-operator ci/prow/vsphere-proxy-e2e-operator ci/prow/wicd-unit-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jrvaldes
Copy link
Contributor Author

/tide refresh

@mtnbikenc
Copy link
Member

Override for ci/prow/vsphere-e2e-operator was missed.

@jrvaldes
Copy link
Contributor Author

jrvaldes commented May 20, 2024

@sebsoto @mansikulkarni96 please /override ci/prow/vsphere-e2e-operator

Copy link
Contributor

openshift-ci bot commented May 20, 2024

@jrvaldes: jrvaldes unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

/override ci/prow/vsphere-e2e-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sebsoto
Copy link
Contributor

sebsoto commented May 29, 2024

/override ci/prow/vsphere-e2e-operator

Copy link
Contributor

openshift-ci bot commented May 29, 2024

@sebsoto: Overrode contexts on behalf of sebsoto: ci/prow/vsphere-e2e-operator

In response to this:

/override ci/prow/vsphere-e2e-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jrvaldes
Copy link
Contributor Author

@sebsoto @mansikulkarni96 the overridden jobs are running, PTAL. they may need another hit.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ddf5f3a and 2 for PR HEAD 477ef3b in total

@sebsoto
Copy link
Contributor

sebsoto commented May 31, 2024

/override ci/prow/azure-e2e-upgrade ci/prow/platform-none-vsphere-e2e-operator

Copy link
Contributor

openshift-ci bot commented May 31, 2024

@sebsoto: Overrode contexts on behalf of sebsoto: ci/prow/azure-e2e-upgrade, ci/prow/platform-none-vsphere-e2e-operator

In response to this:

/override ci/prow/azure-e2e-upgrade ci/prow/platform-none-vsphere-e2e-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sebsoto
Copy link
Contributor

sebsoto commented May 31, 2024

/override ci/prow/aws-e2e-operator ci/prow/aws-e2e-upgrade ci/prow/azure-e2e-operator ci/prow/azure-e2e-upgrade ci/prow/gcp-e2e-operator ci/prow/nutanix-e2e-operator ci/prow/platform-none-vsphere-e2e-operator ci/prow/vsphere-proxy-e2e-operator ci/prow/wicd-unit-vsphere

Copy link
Contributor

openshift-ci bot commented May 31, 2024

@sebsoto: Overrode contexts on behalf of sebsoto: ci/prow/aws-e2e-operator, ci/prow/aws-e2e-upgrade, ci/prow/azure-e2e-operator, ci/prow/azure-e2e-upgrade, ci/prow/gcp-e2e-operator, ci/prow/nutanix-e2e-operator, ci/prow/platform-none-vsphere-e2e-operator, ci/prow/vsphere-proxy-e2e-operator, ci/prow/wicd-unit-vsphere

In response to this:

/override ci/prow/aws-e2e-operator ci/prow/aws-e2e-upgrade ci/prow/azure-e2e-operator ci/prow/azure-e2e-upgrade ci/prow/gcp-e2e-operator ci/prow/nutanix-e2e-operator ci/prow/platform-none-vsphere-e2e-operator ci/prow/vsphere-proxy-e2e-operator ci/prow/wicd-unit-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sebsoto
Copy link
Contributor

sebsoto commented May 31, 2024

/override ci/prow/vsphere-e2e-operator ci/prow/ci-bundle-wmco-bundle

Copy link
Contributor

openshift-ci bot commented May 31, 2024

@sebsoto: Overrode contexts on behalf of sebsoto: ci/prow/ci-bundle-wmco-bundle, ci/prow/vsphere-e2e-operator

In response to this:

/override ci/prow/vsphere-e2e-operator ci/prow/ci-bundle-wmco-bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 7ebe522 into openshift:master May 31, 2024
12 checks passed
Copy link
Contributor

openshift-ci bot commented May 31, 2024

@jrvaldes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants