Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINC-1215: Upgrade OperatorSDK to 1.33.0 #2108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wgahnagl
Copy link
Contributor

Updates the OperatorSDK to version 1.33.0

@wgahnagl wgahnagl changed the title Upgrade OperatorSDK to 1.33.0 WINC-1215: Upgrade OperatorSDK to 1.33.0 Mar 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2024

@wgahnagl: This pull request references WINC-1215 which is a valid jira issue.

In response to this:

Updates the OperatorSDK to version 1.33.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 12, 2024
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wgahnagl
Once this PR has been reviewed and has the lgtm label, please assign mansikulkarni96 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@sebsoto sebsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makefile Outdated
@@ -106,7 +106,7 @@ build-daemon:

.PHONY: run
run: manifests generate fmt vet ## Run a controller from your host.
go run cmd/operator/main.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change.
This repo has two binaries which are built, WMCO and WICD.
Each should have their own subdirectory under cmd/.

@wgahnagl wgahnagl force-pushed the WINC-1215 branch 3 times, most recently from 4e4d88f to 4fb2db9 Compare March 12, 2024 17:24
@wgahnagl
Copy link
Contributor Author

I don't see any changes related to https://book.kubebuilder.io/migration/manually_migration_guide_gov3_to_gov4#update-kustomize-manifests-with-the-changes-made-so-far, please ensure this is handled.

So the change that the update mentioned is that it's no longer using kustomizev2alpha, which we don't implement anywhere
The changes it's recommending are to be sure that there's no scaffolding updates, but between v3 and v4 in the example, there doesn't seem to be any, and our structure is pretty much the same as the v4 example. I don't think these updates apply to us.

@mansikulkarni96
Copy link
Member

https://book.kubebuilder.io/migration/manually_migration_guide_gov3_to_gov4 mentions following change to the layout:
The controller(s) directory has been moved under a new directory called internal and renamed to singular as well controller

@mansikulkarni96
Copy link
Member

mansikulkarni96 commented Mar 13, 2024

You can use https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4 to compare the scaffolding structure between v3 and v4.
Note: mention if you ran any commands in the commit message after you made the changes.

@wgahnagl wgahnagl force-pushed the WINC-1215 branch 2 times, most recently from a0ffda4 to 70cae61 Compare March 25, 2024 19:49
Updates the OperatorSDK to version 1.33.0

- migrates from go/v3 to go/v4 https://book.kubebuilder.io/migration/manually_migration_guide_gov3_to_gov4
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

@wgahnagl: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saifshaikh48
Copy link
Contributor

I think the kustomize v3 to v4 changes still need to be done -- there's Makefile, go.mod, and config/ dir differences between v3 and v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants