-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WINC-1215: Upgrade OperatorSDK to 1.33.0 #2108
base: master
Are you sure you want to change the base?
Conversation
@wgahnagl: This pull request references WINC-1215 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wgahnagl The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any changes related to https://book.kubebuilder.io/migration/manually_migration_guide_gov3_to_gov4#update-kustomize-manifests-with-the-changes-made-so-far, please ensure this is handled.
Makefile
Outdated
@@ -106,7 +106,7 @@ build-daemon: | |||
|
|||
.PHONY: run | |||
run: manifests generate fmt vet ## Run a controller from your host. | |||
go run cmd/operator/main.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this change.
This repo has two binaries which are built, WMCO and WICD.
Each should have their own subdirectory under cmd/
.
4e4d88f
to
4fb2db9
Compare
So the change that the update mentioned is that it's no longer using kustomizev2alpha, which we don't implement anywhere |
https://book.kubebuilder.io/migration/manually_migration_guide_gov3_to_gov4 mentions following change to the layout: |
You can use https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4 to compare the scaffolding structure between v3 and v4. |
a0ffda4
to
70cae61
Compare
Updates the OperatorSDK to version 1.33.0 - migrates from go/v3 to go/v4 https://book.kubebuilder.io/migration/manually_migration_guide_gov3_to_gov4
@wgahnagl: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Updates the OperatorSDK to version 1.33.0