Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing hive dir (Migrated the configs under hosted-mgmt/hive) #52103

Merged
merged 1 commit into from
May 21, 2024

Conversation

deepsm007
Copy link
Contributor

/cc @bear-redhat @openshift/test-platform

@openshift-ci openshift-ci bot requested review from bear-redhat and a team May 16, 2024 13:03
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 16, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@danilo-gemoli
Copy link
Contributor

Before we go ahead and merge:

  • the hive/ dir isn't being used anymore by any of our automations/services, right?
  • I compared hive/ and hosted-mgmt/ and I found these files to exist in hive/ only, is that expected?
$ comm -23 <(find hive/ | xargs -I{} basename {} | sort) <(find hosted-mgmt/ | xargs -I{} basename {} | sort)
00_namespaces.yaml
admin_config-updater_rbac.yaml
admins_stackrox-cluster-pool_rbac.yaml
_hive_alertmanagerconfig.yaml
hive-alerts_prometheusrule.yaml
hive_hiveconfig.yaml
hive_ns.yaml
hive_servicemonitor.yaml
install-config-4-13_secret.yaml
oauth.yaml
ocp-4.13_clusterpool.yaml
ocp-release-4.12.56-x86-64-for-4.12.0-0-to-4.13.0-0_clusterimageset.yaml
ocp-release-4.13.41-x86-64-for-4.13.0-0-to-4.14.0-0_clusterimageset.yaml
ocp-release-4.14.24-x86-64-for-4.14.0-0-to-4.15.0-0_clusterimageset.yaml
ocp-release-4.15.12-x86-64-for-4.15.0-0-to-4.16.0-0_clusterimageset.yaml
openshift-user-workload-monitoring_cm.yaml
stackrox

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2024
@openshift-ci-robot
Copy link
Contributor

@deepsm007, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@deepsm007: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@bear-redhat
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
Copy link
Contributor

openshift-ci bot commented May 21, 2024

@deepsm007: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b49deb6 into openshift:master May 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
5 participants