Config object example - WIP

[onmete]

Description

Example of config object and usage.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thoraxe for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[onmete]

There are some alternative approaches too:

• we can use singleton too, if we want to ensure that only one instance of config is used, eg.

class ConfigSingleton:
    pass
config = ConfigSingleton("path/to/config.yaml")

• we can either initialize the singleton here and store it under the config variable, or we can just use the singleton directly in the other parts of the code (like logging at the top of each module that needs logging), eg.

from ols.utils.config import load_config
config = load_config()  # <- this will return the singleton instance

As we don't want to execute the query filters and index loader right away, lazily evaluated singleton might be a better fit than just module constant.

[openshift-ci]

@onmete: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	4624207	link	true	/test unit
ci/prow/integration	4624207	link	true	/test integration
ci/prow/verify	4624207	link	true	/test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tisnik]

@onmete ok to close this one now (your new PR already fixes this one)

[onmete]

closing, implemented in another PR