Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-33082: Add new use cases that requires anonymization #936

Merged
merged 15 commits into from
May 22, 2024
Merged

OCPBUGS-33082: Add new use cases that requires anonymization #936

merged 15 commits into from
May 22, 2024

Conversation

ncaak
Copy link
Contributor

@ncaak ncaak commented May 9, 2024

This PR implements a new data enhancement to...

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • ``

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/gather_cluster_infrastructure_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

  • Yes

Breaking Changes

  • No

References

https://issues.redhat.com/browse/OCPBUGS-33082

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 9, 2024
@openshift-ci-robot
Copy link
Contributor

@ncaak: This pull request references Jira Issue OCPBUGS-33082, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @JoaoFula

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR implements a new data enhancement to...

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • ``

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/gather_cluster_infrastructure_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

  • Yes

Breaking Changes

  • No

References

https://issues.redhat.com/browse/OCPBUGS-33082

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot requested a review from JoaoFula May 9, 2024 15:32
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@ncaak ncaak marked this pull request as ready for review May 9, 2024 15:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2024
@openshift-ci openshift-ci bot requested review from rhrmo and tremes May 9, 2024 15:42
@ncaak ncaak marked this pull request as draft May 10, 2024 09:09
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2024
@ncaak ncaak marked this pull request as ready for review May 15, 2024 15:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2024
@openshift-ci openshift-ci bot requested a review from rluders May 15, 2024 15:51
@ncaak
Copy link
Contributor Author

ncaak commented May 21, 2024

/retest

@tremes
Copy link
Contributor

tremes commented May 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 82e7c86 and 2 for PR HEAD 19a1e99 in total

@tremes
Copy link
Contributor

tremes commented May 22, 2024

/retest

@ncaak
Copy link
Contributor Author

ncaak commented May 22, 2024

/test e2e-gcp-ovn-techpreview

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a0f0ab8 and 1 for PR HEAD 19a1e99 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 868f543 into openshift:master May 22, 2024
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@ncaak: Jira Issue OCPBUGS-33082: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33082 has been moved to the MODIFIED state.

In response to this:

This PR implements a new data enhancement to...

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • ``

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/gather_cluster_infrastructure_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

  • Yes

Breaking Changes

  • No

References

https://issues.redhat.com/browse/OCPBUGS-33082

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 22, 2024

@ncaak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.17.0-202405221910.p0.g868f543.assembly.stream.el9 for distgit ose-insights-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremes tremes tremes left review comments

@JoaoFula JoaoFula Awaiting requested review from JoaoFula

@rhrmo rhrmo Awaiting requested review from rhrmo

@rluders rluders Awaiting requested review from rluders

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ncaak @openshift-ci-robot @tremes @openshift-bot