-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git import form #931
Git import form #931
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #931 +/- ##
==========================================
- Coverage 85.27% 84.41% -0.86%
==========================================
Files 597 582 -15
Lines 15060 14024 -1036
Branches 4211 3902 -309
==========================================
- Hits 12843 11839 -1004
+ Misses 2087 2054 -33
- Partials 130 131 +1
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
? touched && !error | ||
? ValidatedOptions.success | ||
: ValidatedOptions.error | ||
: ValidatedOptions.default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const validated =touched
? !error
? ValidatedOptions.success
: ValidatedOptions.error: ValidatedOptions.default;
track('Component Create', { | ||
component_name: c.metadata.name, | ||
component_id: c.metadata.uid, | ||
component_name: component.metadata.name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
component.metadata?
09bc2b9
to
79198ec
Compare
[test] |
: ValidatedOptions.default; | ||
return ( | ||
<> | ||
<InputField |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sahil143 Do we also also support an internal source URL? Basically something which cannot be determined as Github, Bitbucket or Gitlab?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we support internal source URLs as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sahil143 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sahil143: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Fixes
https://issues.redhat.com/browse/HAC-5714
Description
Simplified Git Import flow
Type of change
Screen shots / Gifs for design review
How to test or reproduce?
Browser conformance: