Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git import form #931

Merged
merged 6 commits into from
May 28, 2024
Merged

Git import form #931

merged 6 commits into from
May 28, 2024

Conversation

sahil143
Copy link
Contributor

Fixes

https://issues.redhat.com/browse/HAC-5714

Description

Simplified Git Import flow

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

Kapture 2024-05-16 at 16 49 37
Kapture 2024-05-16 at 16 59 16

How to test or reproduce?

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 84.41%. Comparing base (5715421) to head (fb173f0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
- Coverage   85.27%   84.41%   -0.86%     
==========================================
  Files         597      582      -15     
  Lines       15060    14024    -1036     
  Branches     4211     3902     -309     
==========================================
- Hits        12843    11839    -1004     
+ Misses       2087     2054      -33     
- Partials      130      131       +1     
Files Coverage Δ
...omponents/ApplicationDetails/ApplicationHeader.tsx 100.00% <100.00%> (ø)
...onents/ApplicationDetails/ApplicationThumbnail.tsx 100.00% <100.00%> (ø)
...portForm/ApplicationSection/ApplicationSection.tsx 100.00% <100.00%> (ø)
...s/ImportForm/ComponentSection/ComponentSection.tsx 100.00% <100.00%> (ø)
...ponents/ImportForm/ComponentSection/GitOptions.tsx 100.00% <100.00%> (ø)
...nts/ImportForm/PipelineSection/PipelineSection.tsx 100.00% <100.00%> (ø)
src/components/ImportForm/validation.utils.ts 100.00% <100.00%> (ø)
...nents/IntegrationTest/IntegrationTestForm/types.ts 100.00% <ø> (ø)
...Test/IntegrationTestForm/utils/validation-utils.ts 100.00% <100.00%> (ø)
...eService/ReleasePlan/ReleasePlanForm/form-utils.ts 89.74% <100.00%> (ø)
... and 24 more

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5715421...fb173f0. Read the comment docs.

? touched && !error
? ValidatedOptions.success
: ValidatedOptions.error
: ValidatedOptions.default;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const validated =touched
    ? !error
      ? ValidatedOptions.success
      : ValidatedOptions.error: ValidatedOptions.default;
     

track('Component Create', {
component_name: c.metadata.name,
component_id: c.metadata.uid,
component_name: component.metadata.name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

component.metadata?

@sahil143 sahil143 force-pushed the git-import-form branch 3 times, most recently from 09bc2b9 to 79198ec Compare May 23, 2024 07:43
@Katka92
Copy link
Contributor

Katka92 commented May 23, 2024

[test]

: ValidatedOptions.default;
return (
<>
<InputField
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahil143 Do we also also support an internal source URL? Basically something which cannot be determined as Github, Bitbucket or Gitlab?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we support internal source URLs as well.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2024
@sahil143
Copy link
Contributor Author

update screenshot for Components section
image

Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also generate component name based on git repo name.
Screenshot 2024-05-28 at 2 31 20 PM

Copy link
Contributor

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sahil143
Once this PR has been reviewed and has the lgtm label, please ask for approval from rohitkrai03. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 28, 2024

@sahil143: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rohitkrai03 rohitkrai03 merged commit 5de16c2 into openshift:main May 28, 2024
3 of 6 checks passed
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants