Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-33869: i18n - Download and merge French and Spanish languages translations in the OCP Console #13861

Merged
merged 1 commit into from
May 20, 2024
Merged

OCPBUGS-33869: i18n - Download and merge French and Spanish languages translations in the OCP Console #13861

merged 1 commit into from
May 20, 2024

Conversation

cyril-ui-developer
Copy link
Contributor

@cyril-ui-developer cyril-ui-developer commented May 16, 2024 •
edited

Adding latest translations from Memsource project https://cloud.memsource.com/web/project2/show/TBjFI3T6ck8Bd92vkQmtk3

Before:

Screenshot 2024-05-16 at 2 34 20 PM Screenshot 2024-05-16 at 2 34 30 PM

After:

Screenshot 2024-05-16 at 2 34 56 PM Screenshot 2024-05-16 at 2 35 12 PM

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
@openshift-ci openshift-ci bot requested review from cloudbehl and gkarat May 16, 2024 13:42
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console component/git-service Related to git-service component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition component/olm Related to OLM component/pipelines Related to pipelines-plugin component/shared Related to console-shared component/topology Related to topology kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels May 16, 2024
@cyril-ui-developer cyril-ui-developer force-pushed the i18n-fr-es-langs-translations branch 2 times, most recently from bc4e068 to 5700bef Compare May 16, 2024 16:28
@cyril-ui-developer cyril-ui-developer changed the title [WIP] chore(i18n): update translations CONSOLE-3986: Enable French and Spanish in the OCP Console May 16, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2024 •
edited by openshift-ci bot

@cyril-ui-developer: This pull request references CONSOLE-3986 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Adding latest translations from Memsource project https://cloud.memsource.com/web/project2/show/TBjFI3T6ck8Bd92vkQmtk3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2024 •
edited by openshift-ci bot

@cyril-ui-developer: This pull request references CONSOLE-3986 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Adding latest translations from Memsource project https://cloud.memsource.com/web/project2/show/TBjFI3T6ck8Bd92vkQmtk3

Before:

Screenshot 2024-05-16 at 2 34 20 PM Screenshot 2024-05-16 at 2 34 30 PM

After:

Screenshot 2024-05-16 at 2 34 56 PM Screenshot 2024-05-16 at 2 35 12 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cyril-ui-developer cyril-ui-developer changed the title CONSOLE-3986: Enable French and Spanish in the OCP Console OCPBUGS-33869: Add French and Spanish languages traslations in the OCP Console May 17, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 17, 2024
@jhadvig
Copy link
Member

jhadvig commented May 17, 2024

/label acknowledge-critical-fixes-only
/lgtm
/approve

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label May 17, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@openshift-bot
Copy link
Contributor

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 17, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Jira Issue OCPBUGS-33869, which is invalid:

  • expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cyril-ui-developer
Copy link
Contributor Author

/retest

@cyril-ui-developer
Copy link
Contributor Author

/test e2e-gcp-console

@cyril-ui-developer
Copy link
Contributor Author

/retest

1 similar comment
@cyril-ui-developer
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 19, 2024

@cyril-ui-developer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cyril-ui-developer
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-33869, which is invalid:

  • expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cyril-ui-developer
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-33869, which is invalid:

  • expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cyril-ui-developer
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 20, 2024
@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-33869, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 81b150b into openshift:master May 20, 2024
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: Jira Issue OCPBUGS-33869: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33869 has been moved to the MODIFIED state.

In response to this:

Adding latest translations from Memsource project https://cloud.memsource.com/web/project2/show/TBjFI3T6ck8Bd92vkQmtk3

Before:

Screenshot 2024-05-16 at 2 34 20 PM Screenshot 2024-05-16 at 2 34 30 PM

After:

Screenshot 2024-05-16 at 2 34 56 PM Screenshot 2024-05-16 at 2 35 12 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cyril-ui-developer
Copy link
Contributor Author

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link

@cyril-ui-developer: new pull request created: #13870

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 20, 2024
Merged
@cyril-ui-developer cyril-ui-developer mentioned this pull request May 20, 2024
Closed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.17.0-202405201608.p0.g81b150b.assembly.stream.el9 for distgit openshift-enterprise-console.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

@gkarat gkarat Awaiting requested review from gkarat

@yapei yapei Awaiting requested review from yapei

Assignees

@jhadvig jhadvig

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/git-service Related to git-service component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition component/olm Related to OLM component/pipelines Related to pipelines-plugin component/shared Related to console-shared component/topology Related to topology jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cyril-ui-developer @openshift-ci-robot @jhadvig @openshift-bot @openshift-cherrypick-robot