OCPBUGS-32710: pkg/storage/s3: use force path style in favour of virtual hosted style config

[flavianmissi]

the latest upgrade of our openshift/docker-distribution fork brought in a patch introducing forcepathstyle configuration, which was mistakenly merged the openshift only virtualhostedstyle configuration.

to workaround the issue we simply drop the use of virtualhostedstyle in favour of forcepathstyle.

we will eventually remove our custom virtualhostedstyle path from our docker-distribution fork, but using
.spec.storage.s3.virtualHostedStyle should work as expected regardless.

[openshift-ci-robot]

@flavianmissi: This pull request references Jira Issue OCPBUGS-32710, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

the latest upgrade of our openshift/docker-distribution fork brought in a patch introducing forcepathstyle configuration, which was mistakenly merged the openshift only virtualhostedstyle configuration.

to workaround the issue we simply drop the use of virtualhostedstyle in favour of forcepathstyle.

we will eventually remove our custom virtualhostedstyle path from our docker-distribution fork, but using
.spec.storage.s3.virtualHostedStyle should work as expected regardless.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[flavianmissi]

let's hold for pre-merge testing
/hold

[flavianmissi]

/jira refresh

[openshift-ci-robot]

@flavianmissi: This pull request references Jira Issue OCPBUGS-32710, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[flavianmissi]

FTR this needs to be tested in both AWS S3 as well as IBM COS (apparently the virtual hosted style was hard coded there to false)

[flavianmissi]

/retest

[xiuwang]

@flavianmissi Hi, could I understand if REGISTRY_STORAGE_S3_FORCEPATHSTYLE=true, our retrieve blob address should be like https://s3-endpoint.etc/bucket-name/docker/registry/v2/blobs/sha256/<>/data ?

[flavianmissi]

Hi @xiuwang - yes that is my understanding as well!

[xiuwang]

/label qe-approved

[xiuwang]

/label cherry-pick-approved

[flavianmissi]

/jira refresh

[openshift-ci-robot]

@flavianmissi: This pull request references Jira Issue OCPBUGS-32710, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiuwang

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[flavianmissi]

/hold cancel

[flavianmissi]

/jira refresh

[openshift-ci-robot]

@flavianmissi: This pull request references Jira Issue OCPBUGS-32710, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiuwang

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[flavianmissi]

We're seeing failures on a test in vsphere in another PR - I'll try to run that same test against this PR to see if I can reproduce the issue (and confirm it's unrelated to that PR).
/test e2e-vsphere-operator

[dmage]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dmage,flavianmissi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

[openshift-ci-robot]

@openshift-bot: This pull request references Jira Issue OCPBUGS-32710, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiuwang

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

[openshift-ci-robot]

@openshift-bot: This pull request references Jira Issue OCPBUGS-32710, which is invalid:

• expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[flavianmissi]

/jira refresh

[openshift-ci-robot]

@flavianmissi: This pull request references Jira Issue OCPBUGS-32710, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiuwang

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 58e1ceb and 2 for PR HEAD fde302b in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a259a21 and 1 for PR HEAD fde302b in total

[openshift-ci]

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@flavianmissi: Jira Issue OCPBUGS-32710: All pull requests linked via external trackers have merged:

• openshift/cluster-image-registry-operator#1028

Jira Issue OCPBUGS-32710 has been moved to the MODIFIED state.

In response to this:

the latest upgrade of our openshift/docker-distribution fork brought in a patch introducing forcepathstyle configuration, which was mistakenly merged the openshift only virtualhostedstyle configuration.

to workaround the issue we simply drop the use of virtualhostedstyle in favour of forcepathstyle.

we will eventually remove our custom virtualhostedstyle path from our docker-distribution fork, but using
.spec.storage.s3.virtualHostedStyle should work as expected regardless.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-image-registry-operator-container-v4.17.0-202405212243.p0.g053bc77.assembly.stream.el9 for distgit ose-cluster-image-registry-operator.
All builds following this will include this PR.

[flavianmissi]

/cherry-pick release-4.16

[openshift-cherrypick-robot]

@flavianmissi: new pull request created: #1042

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.