Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft pull request Branch: feature/alarms+anomaly detection #1222

Draft
wants to merge 176 commits into
base: master
Choose a base branch
from
Draft

Draft pull request Branch: feature/alarms+anomaly detection #1222

wants to merge 176 commits into from

Conversation

PepijnMuskens
Copy link
Collaborator

Still work in progress but has the general anomaly detection functionality working with 3 detection methods.

Also includes Nina's work from the alarms up until dec. 22 2023

NinaBianca and others added 30 commits February 20, 2023 17:26
@NinaBianca
Commit alarm object
427fc1e
@NinaBianca
Created alarm overview page
b43b016
@NinaBianca
Added initial JSON rule action for alarms
76b9ce9
@NinaBianca
Groovy testing included
43c8bf9
@NinaBianca
Groovy testing included
a2ac46e
@NinaBianca
alarm resource update
8fc8be1
@NinaBianca
Create and getAll works
52cebbd
@NinaBianca
alarm rule modal updated
b3dd095
@NinaBianca
alarm page enhancements
c94da7a
@NinaBianca
single alarm page updated
4c2215c
@NinaBianca
alarm page enhancements
fee8183
@NinaBianca
alarm page enhancements
882b044 
alarm asset linking
@NinaBianca
AlarmAssetLink methods added
b6997b1
@NinaBianca
bla
eccf9d9
@NinaBianca
alarm rule modal updated
7d1a8e3
@NinaBianca
in progress
3c1180a
@NinaBianca
ugh
0b765b0
@NinaBianca
Commit alarm object
2a40050
@NinaBianca
Created alarm overview page
1cf7bd4
@NinaBianca
Added initial JSON rule action for alarms
4cb8fb0
@NinaBianca
Groovy testing included
8f7be04
@NinaBianca
Groovy testing included
cb48ab3
@NinaBianca
alarm resource update
8904d4b
@NinaBianca
Create and getAll works
9e49ac3
@NinaBianca
alarm rule modal updated
bf057d0
@NinaBianca
alarm page enhancements
b606b03
@NinaBianca
single alarm page updated
7ce5924
@NinaBianca
alarm page enhancements
8526015
@NinaBianca
alarm page enhancements
2bb7ca8 
alarm asset linking
@NinaBianca
AlarmAssetLink methods added
4370755
PepijnMuskens and others added 11 commits December 13, 2023 09:56
NinaBianca and others added 5 commits January 22, 2024 17:16
@NinaBianca
Issues to-do:
9f12b25 
- Finish notification sending
- Add asset to table for wide screen
- Multiselect delete (solve occasional select-all glitch)
@PepijnMuskens
Merge branch 'feature/alarms' of https://github.com/openremote/openre…
cf838e9 
…mote into Branch_feature/alarms+anomaly-detection
@PepijnMuskens
database migration update
c1dad75
@PepijnMuskens
chart tooltip undefined fix
2d9c525
@PepijnMuskens
minor bug fixes
9fdc059
@MartinaeyNL
Copy link
Contributor

MartinaeyNL commented Feb 2, 2024 •
edited

Note (to self):

  • Code is not fully finished; still needs cleanup. Worth some code analysis like SonarLint.
  • This PR partly includes code from Nina regarding the alarms; ignore this.
  • Tests have not been written yet; should be there before merging.
  • Be aware of small changes for local use such as the CI/CD file containing OR_SETUP_RUN_ON_RESTART set to false.
    Needs to be cleaned up before merge.

Almost done with a 1st review, will post start of next week.

MartinaeyNL
MartinaeyNL reviewed Feb 5, 2024
View reviewed changes
...ger/src/main/java/org/openremote/manager/anomalyDetection/AnomalyDectectionResourceImpl.java Show resolved Hide resolved
manager/src/main/java/org/openremote/manager/anomalyDetection/AnomalyDetectionService.java Outdated Show resolved Hide resolved
manager/src/main/java/org/openremote/manager/anomalyDetection/AnomalyDetectionService.java Show resolved Hide resolved
manager/src/main/java/org/openremote/manager/anomalyDetection/AnomalyDetectionService.java Show resolved Hide resolved
manager/src/main/java/org/openremote/manager/anomalyDetection/AnomalyDetectionService.java Show resolved Hide resolved
ui/component/or-attribute-input/src/or-anomaly-config-input.ts Outdated Show resolved Hide resolved
ui/component/or-attribute-input/src/or-anomaly-config-input.ts Outdated Show resolved Hide resolved
ui/component/or-attribute-input/src/index.ts Outdated Show resolved Hide resolved
ui/component/or-attribute-input/src/or-anomaly-config-input.ts Outdated Show resolved Hide resolved
ui/component/or-components/src/or-collapsible-panel.ts Outdated Show resolved Hide resolved
@MartinaeyNL
Copy link
Contributor

MartinaeyNL commented Feb 5, 2024 •
edited

To add some additional notes about the review;

The code was looking good overall! Most of the bits I commented on are code quality related,
simply to maintain reusability or readability. For example in regards to method separation / single responsibility of functions,
or "code cleanup bits" you only spot during reviews like these haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinaeyNL MartinaeyNL MartinaeyNL left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PepijnMuskens @MartinaeyNL @NinaBianca @Pepijn-Muskens