Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Fix tests for PR 871 #907

Merged

Conversation

carlwilson
Copy link
Member

@carlwilson carlwilson commented Mar 5, 2024

Simply fixes test results for #871 which it includes, thanks @prettybits

prettybits and others added 3 commits July 17, 2023 14:46
- moved results files fixed by #871 to regression tests; and
- copy correct results by brute force until following release.
@carlwilson carlwilson assigned carlwilson and unassigned carlwilson Mar 5, 2024
@carlwilson carlwilson added the bug A product defect that needs fixing label Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.06%. Comparing base (0dfd556) to head (3a5c17b).
Report is 1 commits behind head on integration.

Additional details and impacted files
@@                Coverage Diff                @@
##             integration     #907      +/-   ##
=================================================
+ Coverage          47.03%   47.06%   +0.03%     
- Complexity          1102     1103       +1     
=================================================
  Files                 57       57              
  Lines               9083     9083              
  Branches            1623     1623              
=================================================
+ Hits                4272     4275       +3     
+ Misses              4280     4278       -2     
+ Partials             531      530       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlwilson carlwilson merged commit 2637321 into integration Mar 5, 2024
4 checks passed
@carlwilson carlwilson deleted the prettybits-handle-indirect-filter-param-objects branch March 5, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants