fix systemd version recognizing in cgroup hook #2631
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Bug or Feature
The systemd version in cgroup hook is not recognized on miscellaneous systems:
and the cgroups service
pbs_jobs.service
is not started on mom.The command called to get the systemd version is
systemctl --system show --property=Version
.See the result on miscellaneous systems:
but the parsing regex
r'Version=\D*(\d+)'
lacks the string after major version number. The systemd version is not recognized in such cases.Describe Your Change
Change the parsing regex to ignore any string after major version number.
Link to Design Doc
Attach Test and Valgrind Logs/Output
Manual test:
After the fix and importing a new version of the hook, the version is recognized, and the service started: