Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May workshop changes #616

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

May workshop changes #616

wants to merge 5 commits into from

Conversation

patham9
Copy link
Member

@patham9 patham9 commented May 11, 2020

No description provided.

…shop session. And Budget summary improvement.
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #616 into master will decrease coverage by 3.60%.
The diff coverage is 92.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #616      +/-   ##
============================================
- Coverage     71.45%   67.84%   -3.61%     
+ Complexity     2615     2397     -218     
============================================
  Files           107      109       +2     
  Lines          8666     8690      +24     
  Branches       1874     1877       +3     
============================================
- Hits           6192     5896     -296     
- Misses         1852     2053     +201     
- Partials        622      741     +119     
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/opennars/io/Channel.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/org/opennars/main/Nar.java 50.16% <ø> (+0.64%) 39.00 <0.00> (ø)
src/main/java/org/opennars/storage/Memory.java 86.61% <ø> (-4.93%) 33.00 <0.00> (-3.00)
.../org/opennars/control/concept/ProcessJudgment.java 86.20% <100.00%> (-7.98%) 33.00 <0.00> (-6.00)
...java/org/opennars/control/concept/ProcessTask.java 85.00% <100.00%> (+0.78%) 6.00 <0.00> (ø)
src/main/java/org/opennars/entity/BudgetValue.java 59.49% <100.00%> (ø) 21.00 <1.00> (ø)
src/main/java/org/opennars/entity/Task.java 76.59% <100.00%> (-2.95%) 22.00 <2.00> (+1.00) ⬇️
...c/main/java/org/opennars/inference/LocalRules.java 77.47% <100.00%> (-8.64%) 46.00 <1.00> (-15.00)
src/main/java/org/opennars/main/Parameters.java 100.00% <100.00%> (ø) 1.00 <1.00> (ø)
src/main/java/org/opennars/storage/Bag.java 74.38% <100.00%> (+0.46%) 33.00 <1.00> (+3.00)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a16e563...76345b1. Read the comment docs.

…rity in ProcessTask before the task is linked to
Copy link
Contributor

@PtrMan PtrMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why a getter setter for archivement? This is unnecessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants