Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporalProjection() uses double #563

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PtrMan
Copy link
Contributor

@PtrMan PtrMan commented Jul 20, 2019

Adresses #554

@PtrMan PtrMan added the refactor Code changes that dont fix a bug or add functionality label Jul 20, 2019
@codecov
Copy link

codecov bot commented Jul 21, 2019

Codecov Report

Merging #563 into master will decrease coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #563      +/-   ##
============================================
- Coverage     71.11%   70.85%   -0.26%     
+ Complexity     2629     2589      -40     
============================================
  Files           106      106              
  Lines          8741     8657      -84     
  Branches       1905     1875      -30     
============================================
- Hits           6216     6134      -82     
+ Misses         1906     1901       -5     
- Partials        619      622       +3
Impacted Files Coverage Δ Complexity Δ
...in/java/org/opennars/inference/TruthFunctions.java 94.02% <100%> (ø) 44 <0> (ø) ⬇️
src/main/java/org/opennars/entity/Sentence.java 75.74% <100%> (+0.49%) 88 <0> (+1) ⬆️
...c/main/java/org/opennars/inference/LocalRules.java 86.11% <100%> (+1.11%) 61 <0> (+1) ⬆️
src/main/java/org/opennars/entity/TaskLink.java 83.33% <0%> (-4.51%) 20% <0%> (-14%)
...n/java/org/opennars/inference/StructuralRules.java 83.58% <0%> (-1.85%) 169% <0%> (-25%)
...org/opennars/control/TemporalInferenceControl.java 79.36% <0%> (-1.59%) 31% <0%> (-1%)
...ain/java/org/opennars/inference/TemporalRules.java 82.05% <0%> (-0.65%) 68% <0%> (-1%)
...ava/org/opennars/inference/CompositionalRules.java 90.4% <0%> (-0.22%) 182% <0%> (-1%)
.../java/org/opennars/inference/SyllogisticRules.java 77.03% <0%> (+0.42%) 150% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ab661...d878bd7. Read the comment docs.

Copy link
Member

@patham9 patham9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't work if we change confidence to double as your other PR suggests. There shouldn't be floats in there. I suggest doing the change to double in the confidence-to-double PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code changes that dont fix a bug or add functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants