Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Instrumentation #560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add: Instrumentation #560

wants to merge 1 commit into from

Conversation

PtrMan
Copy link
Contributor

@PtrMan PtrMan commented Jul 12, 2019

  • debugging for obvious debugging cases
  • trace for tracing of internal stuff

@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #560 into master will decrease coverage by 0.28%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #560      +/-   ##
============================================
- Coverage     71.11%   70.82%   -0.29%     
+ Complexity     2629     2591      -38     
============================================
  Files           106      107       +1     
  Lines          8741     8661      -80     
  Branches       1905     1875      -30     
============================================
- Hits           6216     6134      -82     
- Misses         1906     1907       +1     
- Partials        619      620       +1
Impacted Files Coverage Δ Complexity Δ
...org/opennars/control/TemporalInferenceControl.java 80.95% <0%> (ø) 32 <0> (ø) ⬇️
...java/org/opennars/control/concept/ProcessGoal.java 75.42% <100%> (ø) 50 <0> (ø) ⬇️
...c/main/java/org/opennars/util/Instrumentation.java 25% <25%> (ø) 1 <1> (?)
src/main/java/org/opennars/entity/TaskLink.java 83.33% <0%> (-4.51%) 20% <0%> (-14%)
...n/java/org/opennars/inference/StructuralRules.java 83.58% <0%> (-1.85%) 169% <0%> (-25%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ab661...64454ad. Read the comment docs.

Copy link
Member

@patham9 patham9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I suggest just removing the debug print, it was only added for debugging, instead of a new boilerplate class that does practically nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants