Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narsese Lexer and Parser #343

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Narsese Lexer and Parser #343

wants to merge 2 commits into from

Conversation

PtrMan
Copy link
Contributor

@PtrMan PtrMan commented Jun 14, 2018

first partially done version.

untested (due to the usual git chaos in GUI)

@PtrMan PtrMan changed the title Lexer: first partially done version Lexer Jun 14, 2018
Copy link
Member

@patham9 patham9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the core need a Lexer? The PR needs to be made much more convincing, as I can't really suggest changing the working parser before we are done with MVP1.

@PtrMan
Copy link
Contributor Author

PtrMan commented Jun 15, 2018

Why not MVP0 - I wouldn't call it working - it is semi-working

@PtrMan
Copy link
Contributor Author

PtrMan commented Jun 15, 2018

Yes because I need this for the rule language (or a approximation of it) and syntax highlighting in GUI

@patham9
Copy link
Member

patham9 commented Jun 15, 2018

because MVP0 should not have experimental stuff. But feel free to add it in nars_lab. I don't mind ideas getting developed incrementally there, which, when mature, eventually make it into nars_core. And personally, as you know, I see the adding of a new parser as mostly a waste of time to make software-philes happy, but I won't dictate how you should spend your time. But also consider that a lot of invalid statements can only be detected after the parsing, after reduction and normalization, and this is what is already happening to a large extent.

@PtrMan
Copy link
Contributor Author

PtrMan commented Jun 15, 2018

That are different responsibilities - and I am aware of it.

@PtrMan PtrMan changed the title Lexer Narsese Lexer and Parser Sep 8, 2018
@opennars opennars deleted a comment Sep 8, 2018
@opennars opennars deleted a comment Sep 8, 2018
@opennars opennars deleted a comment Sep 8, 2018
@opennars opennars deleted a comment Sep 8, 2018
@opennars opennars deleted a comment Sep 8, 2018
@PtrMan
Copy link
Contributor Author

PtrMan commented Sep 8, 2018

This can't be done fully in labs (which is a good idea) because the parser can't be overwritten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants